Bug 105662 - CMakeChecker takes unusually long time to run
Summary: CMakeChecker takes unusually long time to run
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Halton Huo
URL:
Keywords:
Depends on: 121764
Blocks:
  Show dependency tree / graph
 
Reported: 2012-12-21 14:53 PST by WebKit Review Bot
Modified: 2013-09-25 11:00 PDT (History)
9 users (show)

See Also:

Attachments
Patch (11.17 KB, patch)
2013-09-25 10:31 PDT, Patrick R. Gansterer 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-12-21 14:53:27 PST 
CMakeChecker takes unusually long time to run
Requested by dglazkov on #webkit.
Comment 1 Dimitri Glazkov (Google) 2012-12-21 14:55:25 PST 
Not sure why, but when I modify CMakeLists, the check-webkit-style sits there for seconds. It's a beefy machine. It shouldn't do that.
Comment 2 Laszlo Gombos 2013-01-28 09:58:43 PST 
Related commit - http://trac.webkit.org/changeset/137057 .
Comment 3 Rafael Brandao 2013-02-08 16:46:14 PST 
I've experienced this when doing this patch:
https://bugs.webkit.org/attachment.cgi?id=187386&action=review
Comment 4 Patrick R. Gansterer 2013-09-23 01:44:14 PDT 
The problem is that a bunch of regualr expressions is compiled for every line. Caching them (like we do in the cpp checker fixes it). This is done in bug 121764.
Comment 5 Patrick R. Gansterer 2013-09-25 10:31:04 PDT 
Created attachment 212595 [details]
Patch
Comment 6 Ryosuke Niwa 2013-09-25 10:32:18 PDT 
Comment on attachment 212595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212595&action=review

> Tools/Scripts/webkitpy/style/checkers/common.py:46
> +    """Matches the string with the pattern, caching the compiled regexp."""

These comments are pretty useless.
Comment 7 Patrick R. Gansterer 2013-09-25 10:39:29 PDT 
Committed r156403: <http://trac.webkit.org/changeset/156403>