Bug 105651 - Invalid assert in GeolocationClientBlackBerry.cpp
Summary: Invalid assert in GeolocationClientBlackBerry.cpp
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Joe Mason
Depends on:
Reported: 2012-12-21 12:40 PST by Joe Mason
Modified: 2013-01-16 14:32 PST (History)
5 users (show)

See Also:

fix (2.89 KB, patch)
2012-12-21 13:21 PST, Joe Mason
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Mason 2012-12-21 12:40:22 PST
GeolocationClientBlackBerry::cancelPermissionRequest contains an ASSERT that the origin is in m_geolocationRequestMap. But it's perfectly valid for the location to not be in the map - for instance, if GeolocationClientBlackBerry::requestPermission returned immediately, without putting it in the map, because geolocation was disabled. In this case the correct thing to do is just return - there is nothing to be done to cancel the permission.
Comment 1 Joe Mason 2012-12-21 13:21:18 PST
Created attachment 180547 [details]
Comment 2 WebKit Review Bot 2013-01-16 14:32:43 PST
Comment on attachment 180547 [details]

Clearing flags on attachment: 180547

Committed r139925: <http://trac.webkit.org/changeset/139925>
Comment 3 WebKit Review Bot 2013-01-16 14:32:47 PST
All reviewed patches have been landed.  Closing bug.