ASSERT in WebResourceLoadScheduler::scheduleLoad with a crashed NetworkProcess with release build symptoms. To reproduce this find a whole bunch of imgur galleries - I used about 20. Open them all at once and - while they're loading - do a`killall -9 NetworkProcess` SHOULD NEVER BE REACHED /Volumes/SSD-Data/git/OpenSource/Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp(105) : void WebKit::WebResourceLoadScheduler::scheduleLoad(WebCore::ResourceLoader *, WebCore::ResourceLoadPriority) 1 0x109e6e17b WebKit::WebResourceLoadScheduler::scheduleLoad(WebCore::ResourceLoader*, WebCore::ResourceLoadPriority) 2 0x109e6de4c WebKit::WebResourceLoadScheduler::scheduleSubresourceLoad(WebCore::Frame*, WebCore::CachedResource*, WebCore::ResourceRequest const&, WebCore::ResourceLoadPriority, WebCore::ResourceLoaderOptions const&) 3 0x10bf57989 WebCore::CachedResource::load(WebCore::CachedResourceLoader*, WebCore::ResourceLoaderOptions const&) 4 0x10bf4aed4 WebCore::CachedImage::load(WebCore::CachedResourceLoader*, WebCore::ResourceLoaderOptions const&) ... The asserting code is: if (!WebProcess::shared().networkConnection()->connection()->sendSync(Messages::NetworkConnectionToWebProcess::ScheduleResourceLoad(loadParameters), Messages::NetworkConnectionToWebProcess::ScheduleResourceLoad::Reply(identifier), 0)) { // FIXME (NetworkProcess): What should we do if this fails? ASSERT_NOT_REACHED(); } In a release build the assert doesn't fire, but we do add a resourceloader that will never, ever finish loading. That results in leaking resourceloaders each time the NetworkProcess crashes. A resourceloader we can't schedule because we can't get through to the NetworkProcess here should be scheduled to fail. In radar as <rdar://problem/12924845>
Created attachment 180548 [details] Patch v1
Comment on attachment 180548 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=180548&action=review > Source/WebKit2/ChangeLog:10 > + Since these loaders will never succeed in loading we should schedule them to fail on a timer. We could also retry the load, but that's a lot of complexity for a case that should never ever happen. > Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.h:70 > + HashSet<RefPtr<WebCore::ResourceLoader> > m_failedResourceLoaders; I'd appreciate a more descriptive name, this set is not used for regular failed loads (e.g. unreachable host).
http://trac.webkit.org/changeset/138397