Bug 105635 - Invalidation of some SVG filter attributes on HTML content doesn't work
Summary: Invalidation of some SVG filter attributes on HTML content doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-21 07:56 PST by Stephen White
Modified: 2013-01-04 12:41 PST (History)
10 users (show)

See Also:

Attachments
Test case (click on the red box) (514 bytes, text/html)
2012-12-21 07:56 PST, Stephen White 		no flags Details
Patch (6.47 KB, patch)
2012-12-21 09:12 PST, Stephen White 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2012-12-21 07:56:49 PST 
Created attachment 180523 [details]
Test case (click on the red box)

Invalidation of some SVG filter attributes on HTML content doesn't work (see attachment -- clicking on the red box should turn it green).

This is because the HTML RenderLayer invalidation happens only in RenderSVGResourceContainer::markAllClientsForInvalidation() (the bottom section which invalidates m_clientLayers), but attribute changes sometimes go through RenderSVGResourceContainer::markClientForInvalidation(), called by RenderSVGResourceFilter::primitiveAttributeChanged().
Comment 1 Stephen White 2012-12-21 09:12:34 PST 
Created attachment 180528 [details]
Patch
Comment 2 Dirk Schulze 2013-01-04 11:50:05 PST 
Comment on attachment 180528 [details]
Patch

Sounds reasonable for me. r=me.
Comment 3 WebKit Review Bot 2013-01-04 12:41:43 PST 
Comment on attachment 180528 [details]
Patch

Clearing flags on attachment: 180528

Committed r138835: <http://trac.webkit.org/changeset/138835>
Comment 4 WebKit Review Bot 2013-01-04 12:41:47 PST 
All reviewed patches have been landed.  Closing bug.