Bug 105623 - [WK2] REGRESSION(r138232): It made 4 tests timeout
Summary: [WK2] REGRESSION(r138232): It made 4 tests timeout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jussi Kukkonen (jku)
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 79668 95084
  Show dependency tree / graph
 
Reported: 2012-12-21 02:21 PST by Csaba Osztrogonác
Modified: 2013-01-04 02:42 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2012-12-21 05:22 PST, Jussi Kukkonen (jku) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-12-21 02:21:32 PST 
I don't know how is it possible, but it made 4 tests timeout. I 
got it with manual bisecting, so I'm sure this patch is the culprit.

http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/r138232%20%2812003%29/results.html

http/tests/misc/slow-loading-mask.html
http/tests/navigation/back-twice-without-commit.html
fast/repaint/table-hover-on-link.html
fast/events/overflow-viewport-renderer-deleted.html
Comment 1 Jussi Kukkonen (jku) 2012-12-21 04:57:50 PST 
At least GTK and EFL are affected as well. 

We now fail to do a text dump when the text output is empty, but apparently dumping is still expected.

I'll attach a patch.
Comment 2 Jussi Kukkonen (jku) 2012-12-21 05:22:51 PST 
Created attachment 180505 [details]
Patch
Comment 3 WebKit Review Bot 2012-12-21 05:48:17 PST 
Comment on attachment 180505 [details]
Patch

Clearing flags on attachment: 180505

Committed r138368: <http://trac.webkit.org/changeset/138368>
Comment 4 WebKit Review Bot 2012-12-21 05:48:21 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Dominik Röttsches (drott) 2013-01-04 02:42:06 PST 
Thanks for catching this one, Jussi.