Bug 105612 - Maybe a typo error in the comments in PlatformContextSkia.h
Summary: Maybe a typo error in the comments in PlatformContextSkia.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-20 21:04 PST by Qiankun Miao
Modified: 2013-01-14 01:25 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2012-12-20 21:11 PST, Qiankun Miao 		no flags Details | Formatted Diff | Diff
Patch (1.80 KB, patch)
2012-12-21 16:48 PST, Qiankun Miao 		no flags Details | Formatted Diff | Diff
Patch (1.80 KB, patch)
2013-01-09 17:38 PST, Qiankun Miao 		no flags Details | Formatted Diff | Diff
Patch (1.80 KB, patch)
2013-01-09 18:10 PST, Qiankun Miao 		no flags Details | Formatted Diff | Diff
Patch (1.80 KB, patch)
2013-01-09 18:12 PST, Qiankun Miao 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Qiankun Miao 2012-12-20 21:04:03 PST 
Maybe a typo error in the comments in PlatformContextSkia.h
Comment 1 Qiankun Miao 2012-12-20 21:11:56 PST 
Created attachment 180477 [details]
Patch
Comment 2 Justin Novosad 2012-12-21 10:16:03 PST 
Isn't it the other "false" that should be changed to "true"?
Comment 3 Qiankun Miao 2012-12-21 16:48:58 PST 
Created attachment 180576 [details]
Patch
Comment 4 Qiankun Miao 2012-12-21 16:53:35 PST 
(In reply to comment #2)
> Isn't it the other "false" that should be changed to "true"?

Yes. If true, we are rendering to an ImageBuffer which has a canvas object. Updated the patch, please help to review, thanks.
Comment 5 WebKit Review Bot 2012-12-27 07:26:08 PST 
Comment on attachment 180576 [details]
Patch

Rejecting attachment 180576 [details] from commit-queue.

qiankun.miao@intel.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 6 Stephen White 2013-01-09 14:02:30 PST 
Comment on attachment 180576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180576&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by Justin Novosad.

Please change this line back to "Reviewed by NOBODY (OOPS!)".  The commit tools will change it on landing to reflect the actual reviewer.

(See "Changelog files" on http://www.webkit.org/coding/contributing.html).
Comment 7 Qiankun Miao 2013-01-09 17:38:57 PST 
Created attachment 182029 [details]
Patch
Comment 8 Qiankun Miao 2013-01-09 18:10:31 PST 
Created attachment 182039 [details]
Patch
Comment 9 Qiankun Miao 2013-01-09 18:12:51 PST 
Created attachment 182041 [details]
Patch
Comment 10 Stephen White 2013-01-10 06:47:28 PST 
Comment on attachment 182041 [details]
Patch

OK, thanks.  r=me
Comment 11 WebKit Review Bot 2013-01-14 01:24:56 PST 
Comment on attachment 182041 [details]
Patch

Clearing flags on attachment: 182041

Committed r139591: <http://trac.webkit.org/changeset/139591>
Comment 12 WebKit Review Bot 2013-01-14 01:25:00 PST 
All reviewed patches have been landed.  Closing bug.