Bug 105587 - accessibility/svg-remote-element.html is flaky (times out)
Summary: accessibility/svg-remote-element.html is flaky (times out)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominic Mazzoni
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-20 16:05 PST by Dominic Mazzoni
Modified: 2012-12-20 16:59 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.99 KB, patch)
2012-12-20 16:32 PST, Dominic Mazzoni
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Mazzoni 2012-12-20 16:05:49 PST
I think there's a race condition - if the SVG image loads before this line is reached, the runAXTest function won't even be called and the test won't run:

if (window.accessibilityController) {
    document.getElementById("svg-image").addEventListener("load", runAXTest);
}

I can't repro on my dev machine, but I'll bet this happens on a heavily-loaded test machine.
Comment 1 Tony Chang 2012-12-20 16:30:22 PST
Oh, maybe if the image is already in the cache?

Anyway, can call runAXTest at document.onload instead?  I believe onload fires after all the images are loaded.
Comment 2 Dominic Mazzoni 2012-12-20 16:32:29 PST
Created attachment 180439 [details]
Patch
Comment 3 chris fleizach 2012-12-20 16:36:02 PST
Comment on attachment 180439 [details]
Patch

thanks!
Comment 4 WebKit Review Bot 2012-12-20 16:59:20 PST
Comment on attachment 180439 [details]
Patch

Clearing flags on attachment: 180439

Committed r138325: <http://trac.webkit.org/changeset/138325>
Comment 5 WebKit Review Bot 2012-12-20 16:59:24 PST
All reviewed patches have been landed.  Closing bug.