Bug 105581 - [WK2] LocalTerminationDisabler is not needed in WebCookieManager.cpp
Summary: [WK2] LocalTerminationDisabler is not needed in WebCookieManager.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-20 15:00 PST by Alexey Proskuryakov
Modified: 2012-12-20 15:12 PST (History)
3 users (show)

See Also:

Attachments
proposed patch (2.93 KB, patch)
2012-12-20 15:04 PST, Alexey Proskuryakov 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-12-20 15:00:34 PST 
All WebCookieManager functions are synchronous, and all LocalTerminationDisabler does enable/disable a timer that cannot fire inside the function anyway.
Comment 1 Alexey Proskuryakov 2012-12-20 15:04:43 PST 
Created attachment 180419 [details]
proposed patch

In fact, most uses can be removed. Are we doing this just for consistency? I can be convinced to keep it if so.

But posting to stir discussion.
Comment 2 Alexey Proskuryakov 2012-12-20 15:12:01 PST 
OK, landed as <http://trac.webkit.org/changeset/138306>. I'll need to go over other "managers" later anyway.