Bug 105579 - [flexbox] Fix handling of very large flex grow/shrink values
Summary: [flexbox] Fix handling of very large flex grow/shrink values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-20 14:45 PST by Emil A Eklund
Modified: 2012-12-20 15:56 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.96 KB, patch)
2012-12-20 14:47 PST, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch (3.98 KB, patch)
2012-12-20 14:57 PST, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-12-20 14:45:23 PST 
Add isfinite to childSize calculation in RenderFlexibleBox::resolveFlexibleLengths to avoid overflow.
Comment 1 Emil A Eklund 2012-12-20 14:47:37 PST 
Created attachment 180414 [details]
Patch
Comment 2 Tony Chang 2012-12-20 14:51:54 PST 
Comment on attachment 180414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180414&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests (OOPS!).

Need to remove the OOPS. Maybe mention that this is covered by css3/flexbox/flex-algorithm.html.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:988
> +            double extraSpace;

I think you need to initialize this because it might not be set below.
Comment 3 Emil A Eklund 2012-12-20 14:56:44 PST 
(In reply to comment #2)
> > Source/WebCore/rendering/RenderFlexibleBox.cpp:988
> > +            double extraSpace;
> 
> I think you need to initialize this because it might not be set below.

Oops, glad you cough that!
Comment 4 Emil A Eklund 2012-12-20 14:57:08 PST 
Created attachment 180416 [details]
Patch
Comment 5 Emil A Eklund 2012-12-20 15:55:55 PST 
Committed r138312: <http://trac.webkit.org/changeset/138312>