Bug 105576 - JIT: Change uninitialized pointer value -1 to constant
Summary: JIT: Change uninitialized pointer value -1 to constant
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-20 14:03 PST by Michael Saboff
Modified: 2012-12-20 15:21 PST (History)
1 user (show)

See Also:

Attachments
Patch (17.93 KB, patch)
2012-12-20 14:48 PST, Michael Saboff 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-12-20 14:03:21 PST 
The various JIT engines use -1 (0xff....ff depending on pointer size) for a pointer that doesn't point to anything valid.  The value of -1 is just used directly in the code.

This should be changed in two ways.
 1) We should use a symbolic constant so the source code is clearer in what we are doing.
 2) The value of -1 isn't a good value, because it is negative and doesn't aid in debugging.
Comment 1 Michael Saboff 2012-12-20 14:48:41 PST 
Created attachment 180415 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-20 15:21:40 PST 
Comment on attachment 180415 [details]
Patch

Clearing flags on attachment: 180415

Committed r138308: <http://trac.webkit.org/changeset/138308>
Comment 3 WebKit Review Bot 2012-12-20 15:21:43 PST 
All reviewed patches have been landed.  Closing bug.