Bug 105571 - Harden pointers in FastMalloc's singly linked list implementation
Summary: Harden pointers in FastMalloc's singly linked list implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-20 13:15 PST by Oliver Hunt
Modified: 2012-12-20 13:36 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.92 KB, patch)
2012-12-20 13:19 PST, Oliver Hunt 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2012-12-20 13:15:55 PST 
Harden pointers in FastMalloc's singly linked list implementation
Comment 1 Oliver Hunt 2012-12-20 13:19:05 PST 
Created attachment 180397 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-20 13:23:11 PST 
Attachment 180397 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Fa..." exit_code: 1
Source/WTF/wtf/FastMalloc.cpp:687:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:691:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2012-12-20 13:34:07 PST 
Comment on attachment 180397 [details]
Patch

r+, assuming you're performance tested this one something.
Comment 4 Oliver Hunt 2012-12-20 13:36:56 PST 
Committed r138293: <http://trac.webkit.org/changeset/138293>