Bug 105565 - fastAttributeLookupAllowed: classAttr is only animatable by SVG styled elements
Summary: fastAttributeLookupAllowed: classAttr is only animatable by SVG styled elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-20 12:23 PST by Erik Arvidsson
Modified: 2012-12-20 13:41 PST (History)
14 users (show)

See Also:


Attachments
Patch (3.18 KB, patch)
2012-12-20 12:26 PST, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Patch (5.18 KB, patch)
2012-12-20 12:59 PST, Erik Arvidsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2012-12-20 12:23:47 PST
Only consider styled SVG elements for fastAttributeLookupAllowed
Comment 1 Erik Arvidsson 2012-12-20 12:26:36 PST
Created attachment 180386 [details]
Patch
Comment 2 Erik Arvidsson 2012-12-20 12:55:21 PST
A have a more correct patch coming in a sec
Comment 3 Erik Arvidsson 2012-12-20 12:59:06 PST
Created attachment 180393 [details]
Patch
Comment 4 Eric Seidel (no email) 2012-12-20 13:06:14 PST
Comment on attachment 180393 [details]
Patch

Looks reasonable to me.  I've cc'd antti/kling who are the real experts for the fastAttr stuff.
Comment 5 Andreas Kling 2012-12-20 13:09:56 PST
(In reply to comment #4)
> (From update of attachment 180393 [details])
> Looks reasonable to me.  I've cc'd antti/kling who are the real experts for the fastAttr stuff.

LGTM!
Comment 6 Philip Rogers 2012-12-20 13:10:30 PST
(In reply to comment #4)
> (From update of attachment 180393 [details])
> Looks reasonable to me.  I've cc'd antti/kling who are the real experts for the fastAttr stuff.

This also seems reasonable to me. I went through all the animatable elements with the class attribute and it looks like you're covered (seriously, <desc> is stylable?)
Comment 7 Philip Rogers 2012-12-20 13:14:53 PST
(In reply to comment #6)
> (In reply to comment #4)
> > (From update of attachment 180393 [details] [details])
> > Looks reasonable to me.  I've cc'd antti/kling who are the real experts for the fastAttr stuff.
> 
> This also seems reasonable to me. I went through all the animatable elements with the class attribute and it looks like you're covered (seriously, <desc> is stylable?)

It looks like the good folks working on SVG2 have fixed this so we will be able to remove the special if check in the future:
https://svgwg.org/svg2-draft/single-page.html#types-InterfaceSVGElement
Comment 8 WebKit Review Bot 2012-12-20 13:41:22 PST
Comment on attachment 180393 [details]
Patch

Clearing flags on attachment: 180393

Committed r138296: <http://trac.webkit.org/changeset/138296>
Comment 9 WebKit Review Bot 2012-12-20 13:41:27 PST
All reviewed patches have been landed.  Closing bug.