WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
105564
[GTK] Remove plugin process configuration option
https://bugs.webkit.org/show_bug.cgi?id=105564
Summary
[GTK] Remove plugin process configuration option
Martin Robinson
Reported
2012-12-20 12:10:44 PST
Instead of allowing building without the WebKit2 plugin process, it should always be built for the GTK+ port.
Attachments
Patch
(8.59 KB, patch)
2012-12-20 12:33 PST
,
Martin Robinson
cgarcia
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Martin Robinson
Comment 1
2012-12-20 12:33:53 PST
Created
attachment 180387
[details]
Patch
Carlos Garcia Campos
Comment 2
2012-12-20 23:55:32 PST
Comment on
attachment 180387
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=180387&action=review
This will automatically fix
bug #89451
. Thanks!
> Source/WebKit2/ChangeLog:13 > +
I think in-process plugin process is indeed incompatible in GTK+, because WebKit2 depends on GTK+ 3 and plugin process requires GTK+ 2 to work. When built in-process it would use GTK+ 3 and some plugins like flash won't work. You might want to mention it in the ChangeLog to make it clear we are not removing it just for the sake of reducing the configuration options.
Carlos Garcia Campos
Comment 3
2012-12-21 00:04:42 PST
Comment on
attachment 180387
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=180387&action=review
Something happened in my browser and last comment was not included in the comment
> configure.ac:1089 > PKG_CHECK_MODULES(GTK2, gtk+-2.0 >= $GTK2_REQUIRED_VERSION gail >= $GAIL2_REQUIRED_VERSION)
Instead of checking again here if we are building webkit2, you could just move this above to the previous if test "$enable_webkit2" = "yes" block and check if gtk2 is present before unix printing.
Martin Robinson
Comment 4
2012-12-23 12:23:24 PST
Committed
r138425
: <
http://trac.webkit.org/changeset/138425
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug