Bug 105563 - REGRESSION (r138191): Tests crash in ResourceRequest::setStorageSession
Summary: REGRESSION (r138191): Tests crash in ResourceRequest::setStorageSession
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar, Regression
: 105562 105567 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-12-20 12:09 PST by Alexey Proskuryakov
Modified: 2012-12-20 17:19 PST (History)
4 users (show)

See Also:

Attachments
proposed fix (3.75 KB, patch)
2012-12-20 12:13 PST, Alexey Proskuryakov 		sam: review+
Details | Formatted Diff | Diff
more fix (1.46 KB, patch)
2012-12-20 17:13 PST, Alexey Proskuryakov 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Alexey Proskuryakov 2012-12-20 12:12:06 PST 
Mac too.

<rdar://problem/12919524>
Comment 2 Alexey Proskuryakov 2012-12-20 12:13:44 PST 
Created attachment 180384 [details]
proposed fix
Comment 3 Alexey Proskuryakov 2012-12-20 12:14:36 PST 
*** Bug 105562 has been marked as a duplicate of this bug. ***
Comment 4 Alexey Proskuryakov 2012-12-20 13:00:51 PST 
*** Bug 105567 has been marked as a duplicate of this bug. ***
Comment 5 Ryosuke Niwa 2012-12-20 13:05:30 PST 
Comment on attachment 180384 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=180384&action=review

> Source/WebCore/ChangeLog:10
> +        Don't try to appky a session if client canceled the request by setting it ot a null one.

Typos? appky/ot
Comment 6 Alexey Proskuryakov 2012-12-20 13:06:00 PST 
Committed <http://trac.webkit.org/changeset/138288>.
Comment 7 Alexey Proskuryakov 2012-12-20 17:11:00 PST 
Re-opening for more fixup.

http/tests/appcache/main-resource-redirect.html is crashing
Comment 8 Alexey Proskuryakov 2012-12-20 17:13:37 PST 
Created attachment 180447 [details]
more fix
Comment 9 Alexey Proskuryakov 2012-12-20 17:19:47 PST 
Committed <http://trac.webkit.org/changeset/138328>.

Filed bug 105591 about additional badness affecting this test.