Bug 105554 - [Chromium/Mac] Don't send an onclick event from a ctrl-click
Summary: [Chromium/Mac] Don't send an onclick event from a ctrl-click
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: asvitkine
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-20 10:57 PST by asvitkine
Modified: 2013-01-02 14:19 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.92 KB, patch)
2012-12-20 11:02 PST, asvitkine 		no flags Details | Formatted Diff | Diff
Patch (4.92 KB, patch)
2012-12-20 11:57 PST, asvitkine 		no flags Details | Formatted Diff | Diff
Patch (4.93 KB, patch)
2012-12-20 12:59 PST, asvitkine 		no flags Details | Formatted Diff | Diff
Patch (5.10 KB, patch)
2012-12-21 07:35 PST, asvitkine 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description asvitkine 2012-12-20 10:57:38 PST 
[Chromium/Mac] Don't send an onclick event from a ctrl-click
Comment 1 asvitkine 2012-12-20 11:02:14 PST 
Created attachment 180369 [details]
Patch
Comment 2 asvitkine 2012-12-20 11:05:00 PST 
dglazkov: Can you review?
Comment 3 WebKit Review Bot 2012-12-20 11:49:22 PST 
Comment on attachment 180369 [details]
Patch

Attachment 180369 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15450145

New failing tests:
fast/events/controlclick-no-onclick.html
Comment 4 asvitkine 2012-12-20 11:57:37 PST 
Created attachment 180381 [details]
Patch
Comment 5 WebKit Review Bot 2012-12-20 12:47:32 PST 
Comment on attachment 180381 [details]
Patch

Attachment 180381 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15455126

New failing tests:
fast/events/controlclick-no-onclick.html
Comment 6 asvitkine 2012-12-20 12:59:56 PST 
Created attachment 180394 [details]
Patch
Comment 7 Dimitri Glazkov (Google) 2012-12-20 13:49:14 PST 
Comment on attachment 180394 [details]
Patch

Might be good to reach out to Apple folks and see if they could adopt this code, too. Checking for this in WebKit layer seems bad.
Comment 8 asvitkine 2012-12-20 13:53:11 PST 
Who would be a good Apple person to cc here?
Comment 9 Dimitri Glazkov (Google) 2012-12-20 14:08:48 PST 
Alexey, can you look over what Alexei is doing? :)
Comment 10 asvitkine 2012-12-20 14:22:15 PST 
dglazkov: Did you mean to cc an Alexey?
Comment 11 Alexey Proskuryakov 2012-12-20 14:40:06 PST 
Not something I have the time to look into now, but please add a FIXME to consider merging the solutions later.
Comment 12 asvitkine 2012-12-21 07:35:44 PST 
Created attachment 180521 [details]
Patch
Comment 13 asvitkine 2012-12-21 07:36:04 PST 
FIXME added.
Comment 14 WebKit Review Bot 2012-12-21 08:20:07 PST 
Comment on attachment 180521 [details]
Patch

Attachment 180521 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15454441

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Comment 15 WebKit Review Bot 2012-12-21 08:25:30 PST 
Comment on attachment 180521 [details]
Patch

Clearing flags on attachment: 180521

Committed r138380: <http://trac.webkit.org/changeset/138380>
Comment 16 WebKit Review Bot 2012-12-21 08:25:34 PST 
All reviewed patches have been landed.  Closing bug.
Comment 17 Ryosuke Niwa 2013-01-02 14:19:25 PST 
Comment on attachment 180521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180521&action=review

> Source/WebCore/page/EventHandler.cpp:1823
> +    // FIXME: The Mac port achieves the same behavior by checking whether the context menu is currently open in WebPage::mouseEvent(). Consider merging the implementations.

Mac WK2 also need to use this fix.