RESOLVED FIXED Bug 105550
NetworkProcess has no need for suspend/resumePendingRequests 
https://bugs.webkit.org/show_bug.cgi?id=105550
Summary NetworkProcess has no need for suspend/resumePendingRequests
Brady Eidson
Reported 2012-12-20 10:31:01 PST
NetworkProcess has no need for suspend/resumePendingRequests Discussion in https://bugs.webkit.org/show_bug.cgi?id=100479 Most importantly for WebKit2 with the NetworkProcess: "I think the suppression mechanism here exists to prevent resource loads from completing synchronously in the middle of style recalc and resulting in re-entry bugs. All loads through network process should be asynchronous so the problems shouldn't exist at all. I think these can be safely removed." We want to remove these because they are surprisingly hot code and the messaging is showing up on profiles. In radar as <rdar://problem/12866005>
Attachments
Patch v1 (7.20 KB, patch)
2012-12-20 10:36 PST, Brady Eidson 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2012-12-20 10:36:55 PST
Created attachment 180363 [details] Patch v1
Alexey Proskuryakov
Comment 2 2012-12-20 11:42:11 PST
Comment on attachment 180363 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=180363&action=review > Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:166 > + // If this WebProcess has a request suspension count then we shouldn't bother > + // messaging the NetworkProcess. I think that a more detailed explanation would help here. What breaks if this check is removed?
Brady Eidson
Comment 3 2012-12-20 14:21:46 PST
http://trac.webkit.org/changeset/138301
Note You need to log in before you can comment on or make changes to this bug.