Bug 105549 - CodeGen: Make [Reflect] use getIdAttribute and getNameAttribute
Summary: CodeGen: Make [Reflect] use getIdAttribute and getNameAttribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-20 10:12 PST by Erik Arvidsson
Modified: 2012-12-20 14:00 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.21 KB, patch)
2012-12-20 10:19 PST, Erik Arvidsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2012-12-20 10:12:08 PST
CodeGen: Make [Reflect] use getIdAttribute and getNameAttribute
Comment 1 Erik Arvidsson 2012-12-20 10:19:04 PST
Created attachment 180360 [details]
Patch
Comment 2 Erik Arvidsson 2012-12-20 10:22:41 PST
                                      Master           Branch
Bindings/id-getter            runs/s  486.83  ± 9.88%  510.55  ± 3.42%
Bindings/undefined-id-getter  runs/s  913.57  ± 2.63%  939.54  ± 2.03%  2.84% Better
Dromaeo/dom-attr              runs/s  135.81  ± 1.47%  143.38  ± 1.46%  5.57% Better
Comment 3 Andreas Kling 2012-12-20 13:28:50 PST
Comment on attachment 180360 [details]
Patch

Sweet!
Comment 4 WebKit Review Bot 2012-12-20 14:00:37 PST
Comment on attachment 180360 [details]
Patch

Clearing flags on attachment: 180360

Committed r138297: <http://trac.webkit.org/changeset/138297>
Comment 5 WebKit Review Bot 2012-12-20 14:00:41 PST
All reviewed patches have been landed.  Closing bug.