Bug 105533 - Font description not synchronized correctly on orientation affecting property changes
Summary: Font description not synchronized correctly on orientation affecting property...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-20 06:53 PST by Antti Koivisto
Modified: 2012-12-20 14:14 PST (History)
10 users (show)

See Also:

Attachments
patch (3.37 KB, patch)
2012-12-20 07:36 PST, Antti Koivisto 		enrica: review+
Details | Formatted Diff | Diff
Another patch (2.20 KB, patch)
2012-12-20 11:03 PST, Enrica Casucci 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-12-20 06:53:20 PST 
in StyleResolver checkForOrientationChange() function checks if the new computed orientation differs from the parent orientation and updates the style's font description only if it does. This is not correct as that does not guarantee the new font description is actually up to date. We can leave the function with the computed orientation and the font description out of sync.
Comment 1 Antti Koivisto 2012-12-20 07:36:12 PST 
Created attachment 180341 [details]
patch
Comment 2 Enrica Casucci 2012-12-20 10:17:12 PST 
What I don't understand about your fix is why you've removed the knowledge of the parent style entirely.
Is it ok? Would it be better to do something like:


if (childFontOrientation == parentFontOrientation && childGlyphOrientation == parentGlyphOrientation
    && style->fontDescription().orientation() == childFontOrientation)
        return;

It is even a smaller change than yours.
Comment 3 Enrica Casucci 2012-12-20 11:03:57 PST 
Created attachment 180371 [details]
Another patch

I'm uploading another patch with a smaller fix.
Comment 4 Enrica Casucci 2012-12-20 11:26:49 PST 
I've discussed this with Dan and I'm convinced that Antti's approach is the right thing to do.
Comment 5 Enrica Casucci 2012-12-20 14:08:47 PST 
Comment on attachment 180341 [details]
patch

looks good to me. Thanks!
Comment 6 Antti Koivisto 2012-12-20 14:14:53 PST 
http://trac.webkit.org/changeset/138299