Bug 105524 – Web Inspector: extract native heap graph representation into a separate file

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

NativeHeapSnapshotView.js should contain only code related to the native memory profiler UI.

[Yury Semikhatsky]

Created attachment 180315 [details]
Patch

[Alexander Pavlov (apavlov)]

Comment on attachment 180315 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180315&action=review

> Source/WebCore/inspector/front-end/NativeHeapGraph.js:110
> +WebInspector.NativeHeapGraphEdge = function(graph, position)

AFAIK our current approach is that we should have types nested into the top-level type (WI.NativeHeapGraph.Edge). Should ask pfeldman to be absolutely sure if you want to leave it this way.

> Source/WebCore/inspector/front-end/NativeHeapGraph.js:153
> +WebInspector.NativeHeapGraphNode = function(graph, position)

Ditto

[Yury Semikhatsky]

Created attachment 180319 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #2)
> (From update of attachment 180315 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180315&action=review
> 
> > Source/WebCore/inspector/front-end/NativeHeapGraph.js:110
> > +WebInspector.NativeHeapGraphEdge = function(graph, position)
> 
> AFAIK our current approach is that we should have types nested into the top-level type (WI.NativeHeapGraph.Edge). Should ask pfeldman to be absolutely sure if you want to leave it this way.
> 
Done. What is the advantage of that naming scheme over the old one?

> > Source/WebCore/inspector/front-end/NativeHeapGraph.js:153
> > +WebInspector.NativeHeapGraphNode = function(graph, position)
> 
> Ditto
Done.

[Yury Semikhatsky]

Created attachment 180322 [details]
Patch

[Yury Semikhatsky]

Created attachment 180323 [details]
Patch

[Alexander Pavlov (apavlov)]

(In reply to comment #4)
> (In reply to comment #2)
> > (From update of attachment 180315 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=180315&action=review
> > 
> > > Source/WebCore/inspector/front-end/NativeHeapGraph.js:110
> > > +WebInspector.NativeHeapGraphEdge = function(graph, position)
> > 
> > AFAIK our current approach is that we should have types nested into the top-level type (WI.NativeHeapGraph.Edge). Should ask pfeldman to be absolutely sure if you want to leave it this way.
> > 
> Done. What is the advantage of that naming scheme over the old one?

It's a surefire way to avoid typename clashes across the frontend codebase.

[Yury Semikhatsky]

(In reply to comment #7)
> (In reply to comment #4)
> > (In reply to comment #2)
> > > (From update of attachment 180315 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=180315&action=review
> > > 
> > > > Source/WebCore/inspector/front-end/NativeHeapGraph.js:110
> > > > +WebInspector.NativeHeapGraphEdge = function(graph, position)
> > > 
> > > AFAIK our current approach is that we should have types nested into the top-level type (WI.NativeHeapGraph.Edge). Should ask pfeldman to be absolutely sure if you want to leave it this way.
> > > 
> > Done. What is the advantage of that naming scheme over the old one?
> 
> It's a surefire way to avoid typename clashes across the frontend codebase.

I understand how it works in case of WebInspector.Node But is longer WebInspector.NativeHeapGraph.Edge is more safe than WebInspector.NativeHeapGraphEdge?

[Yury Semikhatsky]

Committed r138245: <http://trac.webkit.org/changeset/138245>