Bug 105522 – REGRESSION (r138184): transitions/transitions-parsing.html is failing on GTK

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Zan Dobersek]

The transitions/transitions-parsing.html layout test is failing since r138184 landed.
http://trac.webkit.org/changeset/138184

Diff too large, so just trust me! :>

[Zan Dobersek]

Created attachment 180748 [details]
Patch

[WebKit Review Bot]

Comment on attachment 180748 [details]
Patch

Attachment 180748 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15542218

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

[Zan Dobersek]

(In reply to comment #2)
> (From update of attachment 180748 [details])
> Attachment 180748 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/15542218
> 
> New failing tests:
> inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html

Yeah ... no.

[Xan Lopez]

Just a question, if the configure.ac/makefile bits have no effect how can removing them make a test pass? other than that I support getting rid of them.

[Zan Dobersek]

(In reply to comment #4)
> Just a question, if the configure.ac/makefile bits have no effect how can removing them make a test pass? other than that I support getting rid of them.

Here's the AC_ARG_ENABLE prototype:
> — Macro: AC_ARG_ENABLE (feature, help-string, [action-if-given], [action-if-not-given])

The `enable_css_transforms_animations_transitions_unprefixed` variable is only set to "yes" if the feature is not passed through the arguments. However, current code lists `xslt` as the 'feature', and that is given, so the default value is not assigned. That's why the Automake conditional was not set up and that resulted in the feature define (1 by default) being overriden with a 0 value.

[Xan Lopez]

Comment on attachment 180748 [details]
Patch

Hah, I see, that's amusing actually. r=me

[Zan Dobersek]

Comment on attachment 180748 [details]
Patch

Clearing flags on attachment: 180748

Committed r138795: <http://trac.webkit.org/changeset/138795>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.