<rdar://problem/12729443> DragController has rejected drags onto PluginDocument since the beginning of time. PDFPlugin would rather this weren't the case, as we can guarantee it doesn't have anything else handling drags.
Created attachment 180306 [details] patch
Comment on attachment 180306 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=180306&action=review > we can guarantee it doesn't have anything else handling drags. Not even text fields in PDF forms? > Source/WebCore/page/DragController.cpp:413 > + if (doc->isPluginDocument()) { There is a null check for doc below. Either it's not needed, or this new code can crash. > Source/WebCore/page/DragController.cpp:415 > + const PluginViewBase* pluginView = widget && widget->isPluginViewBase() ? static_cast<const PluginViewBase*>(widget) : 0; I like to have braces around ternary conditions FWIW - it makes them look more like if () conditions.
(In reply to comment #2) > (From update of attachment 180306 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180306&action=review > > > we can guarantee it doesn't have anything else handling drags. > > Not even text fields in PDF forms? Ugh. I will test.
http://trac.webkit.org/changeset/138361
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 180306 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=180306&action=review > > > > > we can guarantee it doesn't have anything else handling drags. > > > > Not even text fields in PDF forms? > > Ugh. I will test. These are OK because they're handled as they would be in a normal page. They get the drag and not the document.