Bug 105494 - [TexMap] Remove ParentChange in TextureMapperLayer.
Summary: [TexMap] Remove ParentChange in TextureMapperLayer.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dongseong Hwang
URL:
Keywords:
Depends on:
Blocks: 110211
  Show dependency treegraph
 
Reported: 2012-12-19 21:39 PST by Dongseong Hwang
Modified: 2013-09-25 07:03 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.91 KB, patch)
2012-12-19 22:03 PST, Dongseong Hwang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2012-12-19 21:39:05 PST
ParentChange is useless, because ChildrenChange is enough. In addition, GraphicsLayer uses setParent() method internally.
Comment 1 Dongseong Hwang 2012-12-19 22:03:21 PST
Created attachment 180278 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-20 13:23:16 PST
Comment on attachment 180278 [details]
Patch

Clearing flags on attachment: 180278

Committed r138291: <http://trac.webkit.org/changeset/138291>
Comment 3 WebKit Review Bot 2012-12-20 13:23:20 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Allan Sandfeld Jensen 2013-09-25 06:28:09 PDT
This patch appears to solve real issues, without it parent/child relations of TextureMapperLayer might disagree because the child lists are changed while being iterated over end up skipping some children.
Comment 5 Noam Rosenthal 2013-09-25 06:35:19 PDT
(In reply to comment #4)
> This patch appears to solve real issues, without it parent/child relations of TextureMapperLayer might disagree because the child lists are changed while being iterated over end up skipping some children.

Wasn't it committed 9 months ago?
Comment 6 Allan Sandfeld Jensen 2013-09-25 07:03:50 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > This patch appears to solve real issues, without it parent/child relations of TextureMapperLayer might disagree because the child lists are changed while being iterated over end up skipping some children.
> 
> Wasn't it committed 9 months ago?

Yes, but after the branch of QtWebKit for 5.0/5.1. And it didn't get cherry-picked because it sounded like a refactoring not a bug-fix. 

Just venting a bit because I just spend half a week tracking this issue down for a customer.