Bug 105479 - [Bugzilla] It’s confusing to show r+ and r- as review flag values on new attachment page
Summary: [Bugzilla] It’s confusing to show r+ and r- as review flag values on new atta...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-19 16:48 PST by Ryosuke Niwa
Modified: 2015-12-07 10:08 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-12-19 16:48:27 PST
It seems misleading that we show r- and r+ as options on new attachment page.

I’ve seen multiple cases where a new contributor mistakenly set r+ or r- flags on their attachments as done in:
https://bugs.webkit.org/show_bug.cgi?id=105463

Since the person attaching a patch shouldn’t be reviewing a patch (unless he/she is attaching a patch he/she has already reviewed but doesn’t that ever happen?), we can probably just remove those flags from new attachment page.