WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 105066
105474
[Shadow DOM] Inserting a shadow host into its own shadow crashes
https://bugs.webkit.org/show_bug.cgi?id=105474
Summary
[Shadow DOM] Inserting a shadow host into its own shadow crashes
Dominic Cooney
Reported
2012-12-19 16:01:43 PST
I am not sure what the correct semantics are, but I think this should throw a DOM hierarchy exception.
Attachments
Patch
(4.82 KB, patch)
2012-12-24 18:56 PST
,
Shinya Kawanaka
dglazkov
: review+
dglazkov
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1
2012-12-24 18:56:52 PST
Created
attachment 180695
[details]
Patch
Dominic Cooney
Comment 2
2012-12-25 06:06:32 PST
Comment on
attachment 180695
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=180695&action=review
This looks right to me.
> LayoutTests/fast/dom/shadow/inserting-shadowroot-to-its-host.html:2 > +<html>
You could omit open and close html and maybe body tags – I don’t think js-test-pre.js synchronously touches body
> LayoutTests/fast/dom/shadow/inserting-shadowroot-to-its-host.html:22 > +container.innerHTML = "";
Be consistent about ' for string literals.
Dimitri Glazkov (Google)
Comment 3
2013-01-05 11:23:26 PST
Comment on
attachment 180695
[details]
Patch Please address Dominic's comments.
Shinya Kawanaka
Comment 4
2013-01-06 20:56:49 PST
http://trac.webkit.org/changeset/138730
has fixed this issue already. *** This bug has been marked as a duplicate of
bug 105066
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug