Bug 105465 – [Chromium] add setIDBFactory method for embedders to call

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Mark Pilgrim (Google)]

[Chromium] add setIDBFactory method for embedders to call

[Mark Pilgrim (Google)]

Created attachment 180227 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Darin Fisher (:fishd, Google)]

Comment on attachment 180227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180227&action=review

> Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:64
> +WebIDBFactory* s_webIDBFactory = 0;

nit: make this a static variable.  that makes it invisible at link time to other .cpp files, and
that means the compiler can generate slightly less code when you access s_webIDBFactory.

[Mark Pilgrim (Google)]

Created attachment 180228 [details]
Patch

[Mark Pilgrim (Google)]

Comment on attachment 180228 [details]
Patch

Nits addressed.

[WebKit Review Bot]

Comment on attachment 180228 [details]
Patch

Clearing flags on attachment: 180228

Committed r138221: <http://trac.webkit.org/changeset/138221>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.