Bug 105465 - [Chromium] add setIDBFactory method for embedders to call
Summary: [Chromium] add setIDBFactory method for embedders to call
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks: 82948
  Show dependency treegraph
 
Reported: 2012-12-19 14:22 PST by Mark Pilgrim (Google)
Modified: 2012-12-19 21:45 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.60 KB, patch)
2012-12-19 14:23 PST, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (2.61 KB, patch)
2012-12-19 14:33 PST, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-12-19 14:22:19 PST
[Chromium] add setIDBFactory method for embedders to call
Comment 1 Mark Pilgrim (Google) 2012-12-19 14:23:54 PST
Created attachment 180227 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-19 14:26:16 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Darin Fisher (:fishd, Google) 2012-12-19 14:30:07 PST
Comment on attachment 180227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180227&action=review

> Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:64
> +WebIDBFactory* s_webIDBFactory = 0;

nit: make this a static variable.  that makes it invisible at link time to other .cpp files, and
that means the compiler can generate slightly less code when you access s_webIDBFactory.
Comment 4 Mark Pilgrim (Google) 2012-12-19 14:33:30 PST
Created attachment 180228 [details]
Patch
Comment 5 Mark Pilgrim (Google) 2012-12-19 14:33:57 PST
Comment on attachment 180228 [details]
Patch

Nits addressed.
Comment 6 WebKit Review Bot 2012-12-19 21:45:31 PST
Comment on attachment 180228 [details]
Patch

Clearing flags on attachment: 180228

Committed r138221: <http://trac.webkit.org/changeset/138221>
Comment 7 WebKit Review Bot 2012-12-19 21:45:35 PST
All reviewed patches have been landed.  Closing bug.