Bug 105464 - Lots of sticky tests failing in WK2
Summary: Lots of sticky tests failing in WK2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL: http://build.webkit.org/results/Apple...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-19 14:07 PST by Simon Fraser (smfr)
Modified: 2012-12-20 11:33 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.02 KB, patch)
2012-12-19 16:36 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (7.08 KB, patch)
2012-12-19 18:45 PST, Simon Fraser (smfr) 		beidson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-12-19 14:07:17 PST 
My recent sticky position changes caused all the CSS sticky ref tests to fail in WK2. See url.
Comment 1 Simon Fraser (smfr) 2012-12-19 14:08:14 PST 
I think the issue is related to layer flushing and DrawingAreaImpl::forceRepaint(). That function doesn't do a flush right away if it hasn't received the message that the UI process is in compositing mode. And these tests enter compositing at page load, so we seem to have a race.
Comment 2 Simon Fraser (smfr) 2012-12-19 14:44:50 PST 
New theory: InjectedBundlePage::resetAfterTest() in the web process is racing with snapshotting in the UI process and resetting the scroll position.
Comment 3 Simon Fraser (smfr) 2012-12-19 16:36:09 PST 
Created attachment 180245 [details]
Patch
Comment 4 Simon Fraser (smfr) 2012-12-19 18:21:35 PST 
This patch altered the InternalSettings::Backup::restore behavior such that page->setCanStartMedia() was called with false before the test, breaking all media tests.
Comment 5 Simon Fraser (smfr) 2012-12-19 18:38:05 PST 
canStartMedia save/restore was added for bug 93913.
Comment 6 Simon Fraser (smfr) 2012-12-19 18:45:00 PST 
Created attachment 180259 [details]
Patch
Comment 7 Simon Fraser (smfr) 2012-12-20 11:33:38 PST 
http://trac.webkit.org/changeset/138278