Bug 105456 - [Regression] text-overflow ellipsis clips content when zoomed
Summary: [Regression] text-overflow ellipsis clips content when zoomed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-19 13:11 PST by Emil A Eklund
Modified: 2012-12-20 18:36 PST (History)
4 users (show)

See Also:


Attachments
Patch (7.28 KB, patch)
2012-12-19 13:17 PST, Emil A Eklund
no flags Details | Formatted Diff | Diff
Patch (8.42 KB, patch)
2012-12-19 13:41 PST, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-12-19 13:11:55 PST
At certain zoom levels text-overflow ellipsis incorrectly clips content and displays the ellipsis even though the full content would fit.

Downstream chromium bug: http://code.google.com/p/chromium/issues/detail?id=144057
Comment 1 Emil A Eklund 2012-12-19 13:17:41 PST
Created attachment 180214 [details]
Patch
Comment 2 Levi Weintraub 2012-12-19 13:37:37 PST
Comment on attachment 180214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180214&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:3203
> +        // FIXME: Use pixelSnappedLogicalRightOffsetForLine instead of snapping it ourselves once the column workaround in said method has been fixed.
> +        int blockRightEdge = logicalRightOffsetForLine(curr->lineTop(), firstLine).round();

Emil and I discussed using pixel snapping methods instead of .round() to make this clearer. I'd also like a bug for the column issue so these two fixmes can be tied together better.
Comment 3 Emil A Eklund 2012-12-19 13:41:37 PST
Created attachment 180219 [details]
Patch
Comment 4 Emil A Eklund 2012-12-19 15:08:56 PST
Committed r138196: <http://trac.webkit.org/changeset/138196>
Comment 5 Mark Rowe (bdash) 2012-12-20 18:36:15 PST
This appears to have caused unnecessarily ellipsization on a number of websites. See bug 105600 for information.