Bug 105450 - Rename shouldBufferData to dataBufferingPolicy
Summary: Rename shouldBufferData to dataBufferingPolicy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-19 11:43 PST by Nate Chapin
Modified: 2012-12-20 12:27 PST (History)
2 users (show)

See Also:


Attachments
patch (15.47 KB, patch)
2012-12-19 11:53 PST, Nate Chapin
no flags Details | Formatted Diff | Diff
Patch for landing (16.98 KB, patch)
2012-12-20 11:51 PST, Nate Chapin
no flags Details | Formatted Diff | Diff
Patch for landing (17.66 KB, patch)
2012-12-20 11:55 PST, Nate Chapin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2012-12-19 11:43:38 PST
The old name implies a boolean, but it's an enum. Rename it to better indicate the data type.
Comment 1 Nate Chapin 2012-12-19 11:53:23 PST
Created attachment 180198 [details]
patch
Comment 2 WebKit Review Bot 2012-12-19 21:56:15 PST
Comment on attachment 180198 [details]
patch

Rejecting attachment 180198 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ual void WebKit::AssociatedURLLoader::loadAsynchronously(const WebKit::WebURLRequest&, WebKit::WebURLLoaderClient*)':
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:347: error: 'struct WebCore::ThreadableLoaderOptions' has no member named 'shouldBufferData'
  CXX(target) out/Release/obj.target/webkit/Source/WebKit/chromium/src/BackForwardListChromium.o
make: *** [out/Release/obj.target/webkit/Source/WebKit/chromium/src/AssociatedURLLoader.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/15405880
Comment 3 Nate Chapin 2012-12-20 11:51:26 PST
Created attachment 180377 [details]
Patch for landing
Comment 4 Nate Chapin 2012-12-20 11:55:30 PST
Created attachment 180378 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-12-20 12:27:50 PST
Comment on attachment 180378 [details]
Patch for landing

Clearing flags on attachment: 180378

Committed r138285: <http://trac.webkit.org/changeset/138285>
Comment 6 WebKit Review Bot 2012-12-20 12:27:54 PST
All reviewed patches have been landed.  Closing bug.