Bug 105447 – Add a function to set the origin hash table

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jon Lee]

Doing this allows a WK2 client to set the hash table upon initialization.

[Radar WebKit Bug Importer]

<rdar://problem/12910985>

[Jon Lee]

Created attachment 180210 [details]
Patch

[Brian Weinstein]

Comment on attachment 180210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180210&action=review

> Source/WebKit2/UIProcess/API/C/WKContext.cpp:348
> +        return;

Do we want to clear the list of origin hashes if we pass null for the dictionary? Or will we pass an empty dictionary for that case?

[Jon Lee]

(In reply to comment #3)
> (From update of attachment 180210 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180210&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKContext.cpp:348
> > +        return;
> 
> Do we want to clear the list of origin hashes if we pass null for the dictionary? Or will we pass an empty dictionary for that case?

The client should pass an empty dictionary to clear the list.

[Brian Weinstein]

Comment on attachment 180210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180210&action=review

> Source/WebKit2/ChangeLog:10
> +        keyed by main frame origin, into the WebContext. That, in turn, notifies all existing web

sets... into the WebContext reads a bit strangely, but not sure what would be better.

> Source/WebKit2/WebProcess/WebProcess.cpp:839
> +        m_plugInAutoStartOrigins.add(hashes[i]);

Is it worth calling didAddPlugInAutoStartOrigin(hashes[i]) here? In case we need to add more to that function.

[Jon Lee]

Comment on attachment 180210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180210&action=review

>> Source/WebKit2/WebProcess/WebProcess.cpp:839
>> +        m_plugInAutoStartOrigins.add(hashes[i]);
> 
> Is it worth calling didAddPlugInAutoStartOrigin(hashes[i]) here? In case we need to add more to that function.

Sure, I can call that instead.

[Jon Lee]

Committed r138203: <http://trac.webkit.org/changeset/138203>