Bug 105445 - WebKitCSSTransformValue::customCssText() should always allocate once
Summary: WebKitCSSTransformValue::customCssText() should always allocate once
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-19 09:37 PST by Benjamin Poulain
Modified: 2013-01-04 12:31 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.53 KB, patch)
2012-12-19 09:47 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (4.53 KB, patch)
2012-12-19 12:04 PST, Benjamin Poulain 		menard: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-12-19 09:37:34 PST 
The StringBuilder in WebKitCSSTransformValue::customCssText() has the unfortunate side effect of causing multiple String allocations.
Comment 1 Benjamin Poulain 2012-12-19 09:47:45 PST 
Created attachment 180184 [details]
Patch
Comment 2 Build Bot 2012-12-19 10:18:30 PST 
Comment on attachment 180184 [details]
Patch

Attachment 180184 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15418643
Comment 3 Benjamin Poulain 2012-12-19 12:04:09 PST 
Created attachment 180202 [details]
Patch
Comment 4 Alexis Menard (darktears) 2013-01-03 15:54:03 PST 
Comment on attachment 180202 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180202&action=review

Ok with comments.

> Source/WebCore/ChangeLog:9
> +        it was typically done with 2 memory allocation due to the string size in StringBuilder.

Typo. allocation -> allocations.

> Source/WebCore/ChangeLog:11
> +        This patch change to code to use the String Concatenate opeartions in order

Typo. Fix when landing.
Comment 5 Benjamin Poulain 2013-01-04 12:31:07 PST 
Committed r138829: <http://trac.webkit.org/changeset/138829>