Bug 105440 - [BlackBerry] RSS reader mangles UTF-8
Summary: [BlackBerry] RSS reader mangles UTF-8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-19 08:38 PST by Cosmin Truta
Modified: 2012-12-19 21:29 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.68 KB, patch)
2012-12-19 08:48 PST, Cosmin Truta 		yong.li.webkit: review-
yong.li.webkit: commit-queue-
Details | Formatted Diff | Diff
Patch (4.72 KB, patch)
2012-12-19 09:22 PST, Cosmin Truta 		no flags Details | Formatted Diff | Diff
Patch (4.72 KB, patch)
2012-12-19 10:05 PST, Cosmin Truta 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cosmin Truta 2012-12-19 08:38:46 PST 
Strange characters appear in the translations of RSS feeds which contain letters that can't be encoded in ASCII. This happens because the UTF-8 text is wrongly interpreted as Latin-1.
Example: umlauts don't show up correctly: http://ml.spiegel.de/rss.do?id=politik
Comment 1 Cosmin Truta 2012-12-19 08:48:12 PST 
Created attachment 180176 [details]
Patch
Comment 2 Yong Li 2012-12-19 08:55:33 PST 
Comment on attachment 180176 [details]
Patch

Wait. characters8() isn't null terminated. You should use result.assign(...characters8(), html.length()).
Comment 3 Yong Li 2012-12-19 08:56:07 PST 
Comment on attachment 180176 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180176&action=review

> Source/WebCore/ChangeLog:7
> +
> +        Reviewed by NOBODY (OOPS!).
> +        Reviewed internally by Liam Quinn.

Internal PR#?
Comment 4 Cosmin Truta 2012-12-19 09:22:38 PST 
Created attachment 180181 [details]
Patch
Comment 5 Cosmin Truta 2012-12-19 10:05:52 PST 
Created attachment 180189 [details]
Patch

Same as previous patch, but with a blank line removed.
Comment 6 Yong Li 2012-12-19 14:27:27 PST 
.
Comment 7 WebKit Review Bot 2012-12-19 21:29:27 PST 
Comment on attachment 180189 [details]
Patch

Clearing flags on attachment: 180189

Committed r138218: <http://trac.webkit.org/changeset/138218>
Comment 8 WebKit Review Bot 2012-12-19 21:29:31 PST 
All reviewed patches have been landed.  Closing bug.