Bug 105436 – [GTK][AC] setOpacity doesn't work for GraphicsLayerClutter

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[ChangSeok Oh]

All panels in http://www.webkit.org/blog-files/3d-transforms/poster-circle.html should be transparent, but they aren't.

[ChangSeok Oh]

Created attachment 180170 [details]
Patch

[Joone Hur]

Comment on attachment 180170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180170&action=review

> Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp:597
> +void graphicsLayerActorSetOpacity(GraphicsLayerActor* layer, float value)

I don't think we need to add this method.

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:280
> +    graphicsLayerActorSetOpacity(primaryLayer(), m_opacity);

How about calling clutter_actor_set_opacity directly?

[ChangSeok Oh]

Created attachment 180758 [details]
Patch

[ChangSeok Oh]

Comment on attachment 180170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180170&action=review

Thanks for the comment!

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp:597
>> +void graphicsLayerActorSetOpacity(GraphicsLayerActor* layer, float value)
> 
> I don't think we need to add this method.

Done. I moved this part of the function into GraphicsLayerClutter::updateOpacityOnLayer.

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:280
>> +    graphicsLayerActorSetOpacity(primaryLayer(), m_opacity);
> 
> How about calling clutter_actor_set_opacity directly?

Done.

[Gustavo Noronha (kov)]

Comment on attachment 180758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180758&action=review

> Source/WebCore/ChangeLog:9
> +        Added GraphicsLayerClutter::setOpacity & other stuff. Most codes to set opacity
> +        to GraphicsLayerClutter are taken from mac port.

'& other stuff' doesn't add anything, maybe say 'and wire it to the layer sync mechanism.'? Also I'd say "Based on Mac's GraphicsLayer implementation" instead of the other sentence.

[ChangSeok Oh]

Created attachment 183810 [details]
Patch

[WebKit Review Bot]

Comment on attachment 183810 [details]
Patch

Clearing flags on attachment: 183810

Committed r140350: <http://trac.webkit.org/changeset/140350>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.