Bug 105436 - [GTK][AC] setOpacity doesn't work for GraphicsLayerClutter
Summary: [GTK][AC] setOpacity doesn't work for GraphicsLayerClutter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 105699
  Show dependency tree / graph
 
Reported: 2012-12-19 07:56 PST by ChangSeok Oh
Modified: 2013-01-21 12:24 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.46 KB, patch)
2012-12-19 08:18 PST, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
Patch (3.82 KB, patch)
2012-12-26 11:04 PST, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
Patch (3.80 KB, patch)
2013-01-21 11:39 PST, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2012-12-19 07:56:58 PST 
All panels in http://www.webkit.org/blog-files/3d-transforms/poster-circle.html should be transparent, but they aren't.
Comment 1 ChangSeok Oh 2012-12-19 08:18:55 PST 
Created attachment 180170 [details]
Patch
Comment 2 Joone Hur 2012-12-24 15:27:19 PST 
Comment on attachment 180170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180170&action=review

> Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp:597
> +void graphicsLayerActorSetOpacity(GraphicsLayerActor* layer, float value)

I don't think we need to add this method.

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:280
> +    graphicsLayerActorSetOpacity(primaryLayer(), m_opacity);

How about calling clutter_actor_set_opacity directly?
Comment 3 ChangSeok Oh 2012-12-26 11:04:31 PST 
Created attachment 180758 [details]
Patch
Comment 4 ChangSeok Oh 2012-12-26 11:07:40 PST 
Comment on attachment 180170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180170&action=review

Thanks for the comment!

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp:597
>> +void graphicsLayerActorSetOpacity(GraphicsLayerActor* layer, float value)
> 
> I don't think we need to add this method.

Done. I moved this part of the function into GraphicsLayerClutter::updateOpacityOnLayer.

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:280
>> +    graphicsLayerActorSetOpacity(primaryLayer(), m_opacity);
> 
> How about calling clutter_actor_set_opacity directly?

Done.
Comment 5 Gustavo Noronha (kov) 2013-01-21 10:33:03 PST 
Comment on attachment 180758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180758&action=review

> Source/WebCore/ChangeLog:9
> +        Added GraphicsLayerClutter::setOpacity & other stuff. Most codes to set opacity
> +        to GraphicsLayerClutter are taken from mac port.

'& other stuff' doesn't add anything, maybe say 'and wire it to the layer sync mechanism.'? Also I'd say "Based on Mac's GraphicsLayer implementation" instead of the other sentence.
Comment 6 ChangSeok Oh 2013-01-21 11:39:02 PST 
Created attachment 183810 [details]
Patch
Comment 7 WebKit Review Bot 2013-01-21 12:24:15 PST 
Comment on attachment 183810 [details]
Patch

Clearing flags on attachment: 183810

Committed r140350: <http://trac.webkit.org/changeset/140350>
Comment 8 WebKit Review Bot 2013-01-21 12:24:19 PST 
All reviewed patches have been landed.  Closing bug.