Bug 105422 - Web Inspector: scripts to evaluate on load are not removed from inspector state when Page agent is disabled
Summary: Web Inspector: scripts to evaluate on load are not removed from inspector sta...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-19 05:25 PST by Andrey Kosyakov
Modified: 2012-12-19 07:47 PST (History)
9 users (show)

See Also:

Attachments
Patch (3.09 KB, patch)
2012-12-19 05:35 PST, Andrey Kosyakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-12-19 05:25:22 PST 
We maintain scripts to evaluate on load as part of the inspector state. The scripts are normally managed by the front-end, so their life time should match that of the front-end. Currently, scripts survive the agent being detached, which leads to bugs such as http://crbug.com/165445
Comment 1 Andrey Kosyakov 2012-12-19 05:35:52 PST 
Created attachment 180143 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2012-12-19 05:52:05 PST 
Comment on attachment 180143 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2012-12-19 05:57:45 PST 
Comment on attachment 180143 [details]
Patch

Clearing flags on attachment: 180143

Committed r138150: <http://trac.webkit.org/changeset/138150>
Comment 4 WebKit Review Bot 2012-12-19 05:57:48 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Pavel Feldman 2012-12-19 07:47:34 PST 
Comment on attachment 180143 [details]
Patch

Should we now remove everything?