Bug 105420 - [Qt] Move ImageDiff to the Tools directory root
Summary: [Qt] Move ImageDiff to the Tools directory root
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks: 105303
  Show dependency tree / graph
 
Reported: 2012-12-19 05:23 PST by Thiago Marcos P. Santos
Modified: 2012-12-20 07:29 PST (History)
6 users (show)

See Also:

Attachments
Patch (15.62 KB, patch)
2012-12-19 06:38 PST, Thiago Marcos P. Santos 		no flags Details | Formatted Diff | Diff
Patch (15.62 KB, patch)
2012-12-19 06:39 PST, Thiago Marcos P. Santos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-12-19 05:23:21 PST 
More details on the Meta bug blocked by this bug.
Comment 1 Thiago Marcos P. Santos 2012-12-19 06:38:28 PST 
Created attachment 180157 [details]
Patch
Comment 2 Thiago Marcos P. Santos 2012-12-19 06:39:10 PST 
Created attachment 180158 [details]
Patch

The original ImageDiff code was kept untouched for the sake of git being able to track renames. I'm expecting it to fail on the style checker.
Comment 3 WebKit Review Bot 2012-12-19 06:41:51 PST 
Attachment 180158 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/q..." exit_code: 1
Tools/ImageDiff/qt/ImageDiff.cpp:21:  Alphabetical sorting problem.  [build/include_order] [4]
Tools/ImageDiff/qt/ImageDiff.cpp:57:  One line control clauses should not use braces.  [whitespace/braces] [4]
Tools/ImageDiff/qt/ImageDiff.cpp:123:  One line control clauses should not use braces.  [whitespace/braces] [4]
Tools/ImageDiff/qt/ImageDiff.cpp:140:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 4 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Laszlo Gombos 2012-12-19 07:04:08 PST 
Comment on attachment 180158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180158&action=review

> Tools/ChangeLog:11
> +        * ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro.

Perhaps we should move ImageDiff.pro under ImageDiff/qt/ as it was in the previous location under DumpRenderTree/.
Comment 5 Thiago Marcos P. Santos 2012-12-19 08:26:02 PST 
Comment on attachment 180158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180158&action=review

>> Tools/ChangeLog:11
>> +        * ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro.
> 
> Perhaps we should move ImageDiff.pro under ImageDiff/qt/ as it was in the previous location under DumpRenderTree/.

I tried to make it consistent to WebKitTestRunner that has the .pro located at WebKitTestRunner/WebKitTestRunner.pro
Comment 6 Tor Arne Vestbø 2012-12-20 06:52:31 PST 
Comment on attachment 180158 [details]
Patch

lgtm
Comment 7 WebKit Review Bot 2012-12-20 07:29:32 PST 
Comment on attachment 180158 [details]
Patch

Clearing flags on attachment: 180158

Committed r138253: <http://trac.webkit.org/changeset/138253>
Comment 8 WebKit Review Bot 2012-12-20 07:29:36 PST 
All reviewed patches have been landed.  Closing bug.