RESOLVED FIXED 105412
[EFL][WK2] Move deviceScaleFactor to our view as it's view related 
https://bugs.webkit.org/show_bug.cgi?id=105412
Summary [EFL][WK2] Move deviceScaleFactor to our view as it's view related
Kenneth Rohde Christiansen
Reported 2012-12-19 04:16:11 PST
SSIA
Attachments
Patch (3.26 KB, patch)
2012-12-19 04:17 PST, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2012-12-19 04:17:38 PST
Created attachment 180130 [details] Patch
Laszlo Gombos
Comment 2 2012-12-19 05:02:36 PST
Comment on attachment 180130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180130&action=review Looks good to me but I would appreciate to address the comments below. > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:292 > +void EwkViewImpl::setDeviceScaleFactor(float scale) Nit: Any reason not to use the same symbol name name as the implementation - EwkViewImpl::setIntrinsicDeviceScaleFactor ? > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:302 > + // Note that the scale factor incl page and device scale for now. Nit: incl -> includes
Kenneth Rohde Christiansen
Comment 3 2012-12-19 05:06:49 PST
> > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:292 > > +void EwkViewImpl::setDeviceScaleFactor(float scale) > > Nit: Any reason not to use the same symbol name name as the implementation - EwkViewImpl::setIntrinsicDeviceScaleFactor ? Yeah, because that is an implementation detail. There exists two methods. Elsewhere it is called by the shorter name. > > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:302 > > + // Note that the scale factor incl page and device scale for now. > > Nit: incl -> includes Tried to keep the line short.
WebKit Review Bot
Comment 4 2012-12-19 05:23:37 PST
Comment on attachment 180130 [details] Patch Clearing flags on attachment: 180130 Committed r138146: <http://trac.webkit.org/changeset/138146>
WebKit Review Bot
Comment 5 2012-12-19 05:23:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.