Bug 105412 - [EFL][WK2] Move deviceScaleFactor to our view as it's view related
Summary: [EFL][WK2] Move deviceScaleFactor to our view as it's view related
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Rohde Christiansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-19 04:16 PST by Kenneth Rohde Christiansen
Modified: 2012-12-19 05:23 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.26 KB, patch)
2012-12-19 04:17 PST, Kenneth Rohde Christiansen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2012-12-19 04:16:11 PST 
SSIA
Comment 1 Kenneth Rohde Christiansen 2012-12-19 04:17:38 PST 
Created attachment 180130 [details]
Patch
Comment 2 Laszlo Gombos 2012-12-19 05:02:36 PST 
Comment on attachment 180130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180130&action=review

Looks good to me but I would appreciate to address the comments below.

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:292
> +void EwkViewImpl::setDeviceScaleFactor(float scale)

Nit: Any reason not to use the same symbol name name as the implementation - EwkViewImpl::setIntrinsicDeviceScaleFactor ?

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:302
> +    // Note that the scale factor incl page and device scale for now.

Nit: incl -> includes
Comment 3 Kenneth Rohde Christiansen 2012-12-19 05:06:49 PST 
> > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:292
> > +void EwkViewImpl::setDeviceScaleFactor(float scale)
> 
> Nit: Any reason not to use the same symbol name name as the implementation - EwkViewImpl::setIntrinsicDeviceScaleFactor ?

Yeah, because that is an implementation detail. There exists two methods. Elsewhere it is called by the shorter name.
 
> > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:302
> > +    // Note that the scale factor incl page and device scale for now.
> 
> Nit: incl -> includes

Tried to keep the line short.
Comment 4 WebKit Review Bot 2012-12-19 05:23:37 PST 
Comment on attachment 180130 [details]
Patch

Clearing flags on attachment: 180130

Committed r138146: <http://trac.webkit.org/changeset/138146>
Comment 5 WebKit Review Bot 2012-12-19 05:23:42 PST 
All reviewed patches have been landed.  Closing bug.