Bug 105398 - [BlackBerry] Fix undesired re-entrant calls during media error dialog
Summary: [BlackBerry] Fix undesired re-entrant calls during media error dialog
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Max Feil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-19 00:37 PST by Max Feil
Modified: 2012-12-19 05:14 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.17 KB, patch)
2012-12-19 00:43 PST, Max Feil 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Feil 2012-12-19 00:37:00 PST 
A recent change in libwebview/fe1e943 to the dialog handling means that dialogs are not truly blocking anymore. While the dialog is up, a sub-event loop is called. Therefore the HTML5 media code will continue processing pps messages from mm-renderer, responding to periodic timers, etc., all while a media error dialog call higher up in the stack is waiting for the user to respond. Unfortunately some places in our code do not anticipate being called in a re-entrant way.

This patch restores behaviour to how it was previous to libwebview/fe1e943.
Comment 1 Max Feil 2012-12-19 00:43:13 PST 
Created attachment 180111 [details]
Patch
Comment 2 Rob Buis 2012-12-19 05:07:24 PST 
Comment on attachment 180111 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-12-19 05:14:47 PST 
Comment on attachment 180111 [details]
Patch

Clearing flags on attachment: 180111

Committed r138145: <http://trac.webkit.org/changeset/138145>
Comment 4 WebKit Review Bot 2012-12-19 05:14:51 PST 
All reviewed patches have been landed.  Closing bug.