Bug 105389 - Web Inspector: AuditLauncherView UI components should be disabled until ongoing audit finishes
Summary: Web Inspector: AuditLauncherView UI components should be disabled until ongoi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vivek Galatage
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-18 22:40 PST by Vivek Galatage
Modified: 2012-12-18 23:39 PST (History)
10 users (show)

See Also:

Attachments
Patch (4.31 KB, patch)
2012-12-18 23:09 PST, Vivek Galatage 		no flags Details | Formatted Diff | Diff
Patch (4.36 KB, patch)
2012-12-18 23:16 PST, Vivek Galatage 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vivek Galatage 2012-12-18 22:40:30 PST 
Currently when we are running audits, the button changes its label to "Stop". So we can trigger cancelling of the ongoing audit request.

At the same time, the check-boxes for the category are enabled. So if the user de-selects every category while the request is still on going, the "Stop" button becomes disabled. Hence the audit request cannot be cancelled. This can be avoided if AuditLauncherView UI components are disabled until ongoing audit finishes.

Patch follows.
Comment 1 Vivek Galatage 2012-12-18 23:09:26 PST 
Created attachment 180097 [details]
Patch
Comment 2 Vivek Galatage 2012-12-18 23:16:41 PST 
Created attachment 180099 [details]
Patch
Comment 3 WebKit Review Bot 2012-12-18 23:39:00 PST 
Comment on attachment 180099 [details]
Patch

Clearing flags on attachment: 180099

Committed r138122: <http://trac.webkit.org/changeset/138122>
Comment 4 WebKit Review Bot 2012-12-18 23:39:03 PST 
All reviewed patches have been landed.  Closing bug.