Bug 105386 – REGRESSION(r138097): multiple crashes on media tests (Requested by loislo on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/138097 broke the build:
multiple crashes on media tests (Requested by loislo on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 180088 [details]
ROLLOUT of r138097

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Ilya Tikhonovsky]

http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r138103%20(3966)/compositing/overflow/overflow-compositing-descendant-crash-log.txt


0   com.apple.JavaScriptCore      	0x0000000102c6c173 WTF::StringImpl::StringImpl(char const*, unsigned int, WTF::StringImpl::ConstructFromLiteralTag) + 211 (StringImpl.h:252)
1   com.apple.JavaScriptCore      	0x0000000102c6a309 WTF::StringImpl::StringImpl(char const*, unsigned int, WTF::StringImpl::ConstructFromLiteralTag) + 41 (StringImpl.h:256)
2   com.apple.JavaScriptCore      	0x0000000102c62136 WTF::StringImpl::createFromLiteral(char const*) + 166 (StringImpl.cpp:162)
3   com.apple.JavaScriptCore      	0x0000000102c74f60 WTF::String::String(WTF::ASCIILiteral) + 48 (WTFString.cpp:91)
4   com.apple.JavaScriptCore      	0x0000000102c74f1d WTF::String::String(WTF::ASCIILiteral) + 29 (WTFString.cpp:93)
5   com.apple.WebCore             	0x00000001046f6d16 WebCore::HTMLMediaElement::canPlayType(WTF::String const&, WTF::String const&, WebCore::KURL const&) const + 246 (HTMLMediaElement.cpp:668)
6   com.apple.WebCore             	0x0000000104b816c9 WebCore::jsHTMLMediaElementPrototypeFunctionCanPlayType(JSC::ExecState*) + 697 (JSHTMLMediaElement.cpp:723)

[Ilya Tikhonovsky]

Comment on attachment 180088 [details]
ROLLOUT of r138097

Clearing flags on attachment: 180088

Committed r138114: <http://trac.webkit.org/changeset/138114>

[Ilya Tikhonovsky]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

(In reply to comment #4)
> All reviewed patches have been landed.  Closing bug.

Arg! Thanks for taking care of this, I'll see if I can write a better fix.