RESOLVED FIXED 105378
Adopt new assertion SPI for process suppression on Mac 
https://bugs.webkit.org/show_bug.cgi?id=105378
Summary Adopt new assertion SPI for process suppression on Mac
Kiran Muppala
Reported 2012-12-18 19:15:13 PST
Process suppression for WebKit2 child processes is currently enabled or disabled using AutomaticTermination. This should be replaced with a new assertion SPI specific to process suppression.
Attachments
WIP Patch (7.77 KB, patch)
2012-12-18 19:26 PST, Kiran Muppala 		no flags
DetailsFormatted DiffDiff
WIP Patch (7.94 KB, patch)
2012-12-18 19:51 PST, Kiran Muppala 		no flags
DetailsFormatted DiffDiff
Patch: not ready for commit (8.09 KB, patch)
2012-12-18 22:11 PST, Kiran Muppala 		no flags
DetailsFormatted DiffDiff
Patch (7.67 KB, patch)
2012-12-19 19:24 PST, Kiran Muppala 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kiran Muppala
Comment 1 2012-12-18 19:15:29 PST
<rdar://problem/12893550>
Kiran Muppala
Comment 2 2012-12-18 19:26:49 PST
Created attachment 180076 [details] WIP Patch
Kiran Muppala
Comment 3 2012-12-18 19:51:32 PST
Created attachment 180077 [details] WIP Patch
Kiran Muppala
Comment 4 2012-12-18 19:53:50 PST
(In reply to comment #3) > Created an attachment (id=180077) [details] > Patch In ChildProcess::setApplicationIsOccluded. Simplified the check for occlusion change, by using ChildProcess::isApplicaitonOccluded(). Added a ASSERT.
Kiran Muppala
Comment 5 2012-12-18 22:11:37 PST
Created attachment 180092 [details] Patch: not ready for commit
Kiran Muppala
Comment 6 2012-12-18 22:13:00 PST
(In reply to comment #5) > Created an attachment (id=180092) [details] > Patch Renamed WKSI function to WKNSProcessInfoProcessAssertionWithTypes() to more closely reflect the underlying SPI method and renamed ChildProcess::m_processAssertionVisible to ChildProcess::m_processVisibleAssertion, since the former sounded like the assertion was visible rather than the process being visible.
Kiran Muppala
Comment 7 2012-12-19 19:24:01 PST
Created attachment 180261 [details] Patch
Kiran Muppala
Comment 8 2012-12-19 19:29:45 PST
(In reply to comment #7) > Created an attachment (id=180261) [details] > Patch Mark Rowe reviewed the patch and commented that ChildProcess::enableProcessSuppression and ChildProcess::disableProcessSuppression should be renamed since they are just taking a assertion for process visibility or alternatively he suggested that these methods can be removed entirely and the logic be moved to ChildProcess::setApplicaitonIsOccluded. I preferred the latter idea and hence moved the logic to manage the process visible assertion into ChildProcess::setApplicaitonIsOccluded itself.
WebKit Review Bot
Comment 9 2012-12-19 21:58:54 PST
Comment on attachment 180261 [details] Patch Clearing flags on attachment: 180261 Committed r138226: <http://trac.webkit.org/changeset/138226>
WebKit Review Bot
Comment 10 2012-12-19 21:58:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.