Bug 105357 – [EFL][WebGL] Refactor GLXSurface

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Kalyan]

This is in preparation to add EGL support. There is lot of code related to X which could be shared. This refactoring ensures that we don't have to duplicate any code between our EGL and GLX implementations. In future we might even be able to share this with GraphicsSurfaceGLX

[Kalyan]

Created attachment 180094 [details]
WIP

[Kalyan]

Comment on attachment 180094 [details]
WIP

Not marking it for review yet.

[Kalyan]

Created attachment 180103 [details]
patch

[Kenneth Rohde Christiansen]

Comment on attachment 180103 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180103&action=review

> Source/WebCore/ChangeLog:10
> +        This is in preparation for adding EGL support.
> +        There is lot of X related code which could be shared between our current GLX implementation
> +        and EGL. This patch makes it possible to share the common code but doesn't change any functionality.

What about EGL platforms not having X ?

> Source/WebCore/platform/graphics/surfaces/glx/GLXWindowResources.h:168
> +    GLXFBConfig m_surfaceContextfbConfig;
> +
> +};

unneeded newline

> Source/WebCore/platform/graphics/surfaces/glx/GLXWindowResources.h:172
> +}
> +
> +#endif

unneeded newline

> Source/WebCore/platform/graphics/surfaces/glx/X11WindowResources.h:108
> +    }
> +
> +
> +    XVisualInfo* visualInfo()
> +    {
> +        if (!m_VisualInfo)
> +            surfaceContextConfig();
> +
> +        return m_VisualInfo;
> +    }
> +
> +
> +
> +    bool isXRenderExtensionSupported()

what is up with the newlines?

[Kalyan]

(In reply to comment #4)
> (From update of attachment 180103 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=180103&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        This is in preparation for adding EGL support.
> > +        There is lot of X related code which could be shared between our current GLX implementation
> > +        and EGL. This patch makes it possible to share the common code but doesn't change any functionality.
> 
> What about EGL platforms not having X ?
> 

We need to add support as needed. This moves us in the write direction though as there is clear separation and surface dosen't expect to have X. One would probably need to replace x11windowresources with the right support and things should work.

> what is up with the newlines?
sorry, will fix and upload a new patch

[Build Bot]

Comment on attachment 180103 [details]
patch

Attachment 180103 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15404608

New failing tests:
fast/frames/sandboxed-iframe-attribute-parsing.html

[Kalyan]

Created attachment 180124 [details]
patch

Review fixes

[WebKit Review Bot]

Comment on attachment 180124 [details]
patch

Clearing flags on attachment: 180124

Committed r138140: <http://trac.webkit.org/changeset/138140>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.