Bug 105352 - String improvements in geolocation and notifications modules
Summary: String improvements in geolocation and notifications modules
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-18 14:42 PST by Joseph Pecoraro
Modified: 2013-01-07 15:59 PST (History)
1 user (show)

See Also:

Attachments
[PATCH] Proposed Fix (7.74 KB, patch)
2012-12-18 14:46 PST, Joseph Pecoraro 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2012-12-18 14:42:39 PST 
While reading through the code for Modules/geolocation and Modules/notifications I noticed some string improvements that could be made. Patch to follow.
Comment 1 Joseph Pecoraro 2012-12-18 14:46:18 PST 
Created attachment 180032 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2012-12-19 10:36:46 PST 
Comment on attachment 180032 [details]
[PATCH] Proposed Fix

Given a recent patch with similar changes caused crashes I didn't see I'm going to r- and hold off on this until I can test it further.
Comment 3 Joseph Pecoraro 2013-01-04 12:48:58 PST 
Comment on attachment 180032 [details]
[PATCH] Proposed Fix

Back to r? the earlier concerns do not matter here.
Comment 4 Joseph Pecoraro 2013-01-07 15:59:23 PST 
Landed r139005: <http://trac.webkit.org/changeset/139005>