Bug 105349 - [Chromium/Skia] Check whether bitmap has pixels in image encoders
Summary: [Chromium/Skia] Check whether bitmap has pixels in image encoders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Salomon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-18 14:21 PST by Brian Salomon
Modified: 2012-12-19 09:17 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.23 KB, patch)
2012-12-18 14:24 PST, Brian Salomon 		no flags Details | Formatted Diff | Diff
Patch (3.19 KB, patch)
2012-12-19 05:37 PST, Brian Salomon 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Salomon 2012-12-18 14:21:57 PST 
[Chromium/Skia] Check whether bitmap has pixels in image encoders
Comment 1 Brian Salomon 2012-12-18 14:24:52 PST 
Created attachment 180026 [details]
Patch
Comment 2 Brian Salomon 2012-12-18 14:27:28 PST 
Related cr bug: http://crbug.com/162551
Comment 3 Brian Salomon 2012-12-19 05:37:13 PST 
Created attachment 180144 [details]
Patch
Comment 4 Brian Salomon 2012-12-19 05:38:49 PST 
The failure case was toDataURL on canvas2D when the allocating the readback bitmap failed.
Comment 5 Stephen White 2012-12-19 09:06:36 PST 
Comment on attachment 180144 [details]
Patch

Looks good.  r=me

For testing this type of thing in the future, perhaps we could think about creating a mock SkPixelRef that leaves its pixels NULL when locked.
Comment 6 WebKit Review Bot 2012-12-19 09:17:54 PST 
Comment on attachment 180144 [details]
Patch

Clearing flags on attachment: 180144

Committed r138170: <http://trac.webkit.org/changeset/138170>
Comment 7 WebKit Review Bot 2012-12-19 09:17:57 PST 
All reviewed patches have been landed.  Closing bug.