Bug 105340 - Add a JSScriptRef API to JSC so that we can allow API users to avoid the full cost of reparsing everytime the execute a script.
Summary: Add a JSScriptRef API to JSC so that we can allow API users to avoid the full...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-18 13:20 PST by Oliver Hunt
Modified: 2012-12-18 18:20 PST (History)
6 users (show)

See Also:

Attachments
Patch (22.66 KB, patch)
2012-12-18 13:49 PST, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (22.56 KB, patch)
2012-12-18 17:23 PST, Oliver Hunt 		barraclough: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2012-12-18 13:20:38 PST 
Add a JSScriptRef API to JSC so that we can allow API users to avoid the full cost of reparsing everytime the execute a script.
Comment 1 Oliver Hunt 2012-12-18 13:49:22 PST 
Created attachment 180016 [details]
Patch
Comment 2 WebKit Review Bot 2012-12-18 13:53:55 PST 
Attachment 180016 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSScriptRef.cpp'..." exit_code: 1
Source/JavaScriptCore/API/JSScriptRefPrivate.h:53:  The parameter name "globalContext" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/API/JSScriptRefPrivate.h:65:  The parameter name "globalContext" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/API/JSScriptRefPrivate.h:73:  The parameter name "script" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/API/JSScriptRefPrivate.h:81:  The parameter name "script" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/API/JSScriptRefPrivate.h:92:  The parameter name "script" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 5 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Oliver Hunt 2012-12-18 17:23:37 PST 
Created attachment 180066 [details]
Patch
Comment 4 WebKit Review Bot 2012-12-18 17:28:32 PST 
Attachment 180066 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSScriptRef.cpp'..." exit_code: 1
Source/JavaScriptCore/API/JSScriptRefPrivate.h:73:  The parameter name "script" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/API/JSScriptRefPrivate.h:81:  The parameter name "script" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/API/JSScriptRefPrivate.h:92:  The parameter name "script" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Oliver Hunt 2012-12-18 18:20:36 PST 
Committed r138098: <http://trac.webkit.org/changeset/138098>