Bug 105334 - Input elements with default touch handlers don't update handler counts when changing documents
Summary: Input elements with default touch handlers don't update handler counts when c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-18 12:03 PST by Levi Weintraub
Modified: 2012-12-19 02:32 PST (History)
11 users (show)

See Also:


Attachments
Patch (6.31 KB, patch)
2012-12-18 12:12 PST, Levi Weintraub
jamesr: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (7.39 KB, patch)
2012-12-18 12:24 PST, Levi Weintraub
jamesr: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-12-18 12:03:56 PST
We handled one case in updateType, but not in didMoveToNewDocument.
Comment 1 Levi Weintraub 2012-12-18 12:12:39 PST
Created attachment 179997 [details]
Patch

Fixes the bug.
Comment 2 Early Warning System Bot 2012-12-18 12:18:07 PST
Comment on attachment 179997 [details]
Patch

Attachment 179997 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15404317
Comment 3 Early Warning System Bot 2012-12-18 12:18:24 PST
Comment on attachment 179997 [details]
Patch

Attachment 179997 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15404318
Comment 4 Levi Weintraub 2012-12-18 12:24:53 PST
Created attachment 180002 [details]
Patch

Changing the guards on didRemoveTouchEventTargetNode.
Comment 5 WebKit Review Bot 2012-12-18 17:29:31 PST
Comment on attachment 180002 [details]
Patch

Attachment 180002 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15413342

New failing tests:
fast/events/touch/touch-input-element-change-documents.html
Comment 6 Levi Weintraub 2012-12-18 18:05:08 PST
Committed r138095: <http://trac.webkit.org/changeset/138095>
Comment 7 János Badics 2012-12-19 02:09:26 PST
The test you have added in r138095 and corrected in r138115 still fails on Qt and EFL. I have added detailed information about the fails at https://bugs.webkit.org/show_bug.cgi?id=105406.

Could you have a look at it please?
I will skip this test on Qt until the proper fix. Please unskip it afterwards.
Comment 8 János Badics 2012-12-19 02:32:40 PST
fast/events/touch/touch-input-element-change-documents.html has been skipped in r138134. Please unskip with the proper fix.