Bug 105332 - TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac
Summary: TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-18 11:23 PST by Emil A Eklund
Modified: 2012-12-18 12:09 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.03 KB, patch)
2012-12-18 11:24 PST, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch for landing (2.93 KB, patch)
2012-12-18 11:55 PST, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-12-18 11:23:22 PST 
[ RUN      ] WebCore.LayoutUnitDivision
../src/gtest.cc:2022: Failure
Failed
All tests in the same test case must use the same test fixture
class, so mixing TEST_F and TEST in the same test case is
illegal.  In test case WebCore,
test KURLConstructorDefault is defined using TEST_F but
test LayoutUnitDivision is defined using TEST.  You probably
want to change the TEST to TEST_F or move it to another test
case.
Comment 1 Emil A Eklund 2012-12-18 11:24:49 PST 
Created attachment 179984 [details]
Patch
Comment 2 Levi Weintraub 2012-12-18 11:33:40 PST 
Comment on attachment 179984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179984&action=review

> Tools/ChangeLog:10
> +        compatible with KURL tests as one cannot mix the two types in
> +        the same test suite.

Sad panda!
Comment 3 Emil A Eklund 2012-12-18 11:55:17 PST 
Created attachment 179994 [details]
Patch for landing
Comment 4 Emil A Eklund 2012-12-18 12:05:16 PST 
Moved to separate test suite instead as suggested.
Comment 5 Emil A Eklund 2012-12-18 12:08:54 PST 
Committed r138050: <http://trac.webkit.org/changeset/138050>