Bug 105329 - [BlackBerry] Use midpoint for fixed position heuristic
Summary: [BlackBerry] Use midpoint for fixed position heuristic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrew Lo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-18 11:15 PST by Andrew Lo
Modified: 2012-12-18 12:52 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.54 KB, patch)
2012-12-18 11:24 PST, Andrew Lo
no flags Details | Formatted Diff | Diff
Patch (2.55 KB, patch)
2012-12-18 12:14 PST, Andrew Lo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Lo 2012-12-18 11:15:35 PST
Currently we use a heuristic to determine whether a fixed position element is at the bottom or top of the screen.
We check if the top edge of the layer is in the bottom or top half of the screen.
A better heuristic would be to check if the midpoint of the layer is in the top or bottom half.
Comment 1 Andrew Lo 2012-12-18 11:24:59 PST
Created attachment 179985 [details]
Patch
Comment 2 Rob Buis 2012-12-18 11:27:15 PST
Comment on attachment 179985 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-12-18 11:30:00 PST
Comment on attachment 179985 [details]
Patch

Rejecting attachment 179985 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
commit-queue

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp
Hunk #1 FAILED at 731.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/15401273
Comment 4 Andrew Lo 2012-12-18 12:14:28 PST
Created attachment 179998 [details]
Patch
Comment 5 Rob Buis 2012-12-18 12:17:05 PST
Comment on attachment 179998 [details]
Patch

Another try.
Comment 6 WebKit Review Bot 2012-12-18 12:52:10 PST
Comment on attachment 179998 [details]
Patch

Clearing flags on attachment: 179998

Committed r138056: <http://trac.webkit.org/changeset/138056>
Comment 7 WebKit Review Bot 2012-12-18 12:52:13 PST
All reviewed patches have been landed.  Closing bug.