RESOLVED FIXED 105329
[BlackBerry] Use midpoint for fixed position heuristic 
https://bugs.webkit.org/show_bug.cgi?id=105329
Summary [BlackBerry] Use midpoint for fixed position heuristic
Andrew Lo
Reported 2012-12-18 11:15:35 PST
Currently we use a heuristic to determine whether a fixed position element is at the bottom or top of the screen. We check if the top edge of the layer is in the bottom or top half of the screen. A better heuristic would be to check if the midpoint of the layer is in the top or bottom half.
Attachments
Patch (2.54 KB, patch)
2012-12-18 11:24 PST, Andrew Lo 		no flags
DetailsFormatted DiffDiff
Patch (2.55 KB, patch)
2012-12-18 12:14 PST, Andrew Lo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrew Lo
Comment 1 2012-12-18 11:24:59 PST
Created attachment 179985 [details] Patch
Rob Buis
Comment 2 2012-12-18 11:27:15 PST
Comment on attachment 179985 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2012-12-18 11:30:00 PST
Comment on attachment 179985 [details] Patch Rejecting attachment 179985 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: commit-queue Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp Hunk #1 FAILED at 731. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15401273
Andrew Lo
Comment 4 2012-12-18 12:14:28 PST
Created attachment 179998 [details] Patch
Rob Buis
Comment 5 2012-12-18 12:17:05 PST
Comment on attachment 179998 [details] Patch Another try.
WebKit Review Bot
Comment 6 2012-12-18 12:52:10 PST
Comment on attachment 179998 [details] Patch Clearing flags on attachment: 179998 Committed r138056: <http://trac.webkit.org/changeset/138056>
WebKit Review Bot
Comment 7 2012-12-18 12:52:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.