Bug 105322 - [GTK] Enable Navigation Timing by default
Summary: [GTK] Enable Navigation Timing by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2012-12-18 10:01 PST by Zan Dobersek
Modified: 2012-12-19 08:35 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2012-12-18 10:40 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (4.02 KB, patch)
2012-12-18 11:13 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-12-18 10:01:35 PST 
The Navigation Timing spec has just recently been promoted to W3C Recommendation status.
http://www.w3.org/News/2012#entry-9668

The feature is guarded by the ENABLE_WEB_TIMING feature define. I think it would make sense to now enable it by default in release builds as well.
Comment 1 Zan Dobersek 2012-12-18 10:40:43 PST 
Created attachment 179976 [details]
Patch
Comment 2 Zan Dobersek 2012-12-18 10:56:00 PST 
Comment on attachment 179976 [details]
Patch

Also requires modifications to the GObject bindings GNUmakefile, will upload a new patch.
Comment 3 Zan Dobersek 2012-12-18 11:13:17 PST 
Created attachment 179982 [details]
Patch
Comment 4 Martin Robinson 2012-12-18 11:15:27 PST 
Comment on attachment 179982 [details]
Patch

Looks good. Is this enabled on Chromium?
Comment 5 Zan Dobersek 2012-12-18 11:24:05 PST 
(In reply to comment #4)
> (From update of attachment 179982 [details])
> Looks good. Is this enabled on Chromium?

Yes.
http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/features.gypi#L129

Can also exercise the feature in the latest Chromium release from the dev channel.
Comment 6 Zan Dobersek 2012-12-19 08:35:05 PST 
Comment on attachment 179982 [details]
Patch

Clearing flags on attachment: 179982

Committed r138167: <http://trac.webkit.org/changeset/138167>
Comment 7 Zan Dobersek 2012-12-19 08:35:25 PST 
All reviewed patches have been landed.  Closing bug.