Bug 105321 - [CSS Shaders] Detached identifier after mesh box type is not applied
Summary: [CSS Shaders] Detached identifier after mesh box type is not applied
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Max Vujovic
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-18 10:00 PST by Max Vujovic
Modified: 2013-01-09 15:15 PST (History)
7 users (show)

See Also:

Attachments
Patch (23.34 KB, patch)
2013-01-03 09:52 PST, Max Vujovic 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Vujovic 2012-12-18 10:00:44 PST 
If the "detached" identifier follows a mesh box type identifier, the detached identifier is not applied. In other words, the mesh is still attached. For example:
-webkit-filter: custom(url(shader.vs) mix(url(shader.fs) normal source-atop), 1 1 border-box detached);

Although the mesh box type is being removed from the Filter Effects spec, for now, we continue to accept the mesh box type in parsing because of existing content. Eventually, custom filters will transition to an at-rule syntax, once it is defined.

Patch coming up.
Comment 1 Max Vujovic 2013-01-03 09:52:23 PST 
Created attachment 181181 [details]
Patch
Comment 2 Max Vujovic 2013-01-09 15:04:03 PST 
Comment on attachment 181181 [details]
Patch

Thanks for the review! Setting cq+.
Comment 3 WebKit Review Bot 2013-01-09 15:15:12 PST 
Comment on attachment 181181 [details]
Patch

Clearing flags on attachment: 181181

Committed r139248: <http://trac.webkit.org/changeset/139248>
Comment 4 WebKit Review Bot 2013-01-09 15:15:15 PST 
All reviewed patches have been landed.  Closing bug.