Bug 105316 – [WK2] Create a context client

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Jon Lee]

The web context basically currently has two clients: a download client and a history client. Create a third generic client where miscellaneous calls can be aggregated.

[Radar WebKit Bug Importer]

<rdar://problem/12901762>

[Jon Lee]

Created attachment 179969 [details]
Patch

[WebKit Review Bot]

Attachment 179969 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebKit2/UIProcess/API/C/WKContext.h:49:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

What will go in this client?  Without any context, I am not sure how to review this patch.

[Jon Lee]

A function to notify the context client that the table of auto-start origin hashes has changed.

[Brady Eidson]

Comment on attachment 179969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179969&action=review

r+ with one requested change.

> Source/WebKit2/UIProcess/WebContext.h:374
>      WebHistoryClient m_historyClient;
> +    WebDownloadClient m_downloadClient;
> +    WebContextClient m_client;

Might as well sort these alphabetically as long as you're rearranging them.

[Jon Lee]

Committed r138096: <http://trac.webkit.org/changeset/138096>