Bug 105295 – include missing when building without JIT

• Status: RESOLVED
• Resolution: INVALID
• Component: JavaScriptCore

[Dan Horák]

Created attachment 179938 [details]
add missing include

when building webkitgtk3 1.11.2 on Fedora/s390x with JIT disabled I get the following error:

...
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -Wno-parentheses -fno-exceptions -DENABLE_GLIB_SUPPORT=1 -DBUILDING_CAIRO__=1 -DBUILDING_GTK__=1 -DWTF_CHANGES -DBUILDING_WEBKIT2__=1 -DXP_UNIX -DMOZ_X11 -DWTF_USE_ICU_UNICODE=1 -DWTF_USE_GSTREAMER=1 -DWTF_USE_ACCELERATED_COMPOSITING=1 -DENABLE_3D_RENDERING=1 -DWTF_USE_TEXTURE_MAPPER=1 -DWTF_USE_TEXTURE_MAPPER_GL=1 -DWTF_USE_GLX=1 -DWTF_USE_EGL=1 -DWTF_USE_OPENGL=1 -DNDEBUG -DENABLE_JIT=0 -I./Source -I./Source/JavaScriptCore -I./Source/JavaScriptCore/API -I./Source/JavaScriptCore/assembler -I./Source/JavaScriptCore/bytecode -I./Source/JavaScriptCore/bytecompiler -I./Source/JavaScriptCore/dfg -I./Source/JavaScriptCore/disassembler -I./Source/JavaScriptCore/heap -I./Source/JavaScriptCore/debugger -I./Source/JavaScriptCore/ForwardingHeaders -I./Source/JavaScriptCore/interpreter -I./Source/JavaScriptCore/jit -I./Source/JavaScriptCore/jit -I./Source/JavaScriptCore/llint -I./Source/JavaScriptCore/parser -I./Source/JavaScriptCore/profiler -I./Source/JavaScriptCore/runtime -I./Source/JavaScriptCore/tools -I./Source/JavaScriptCore/yarr -I./DerivedSources/JavaScriptCore -I./Source/WTF -fno-rtti -fstrict-aliasing -O3 -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -D_REENTRANT -I/usr/include -O2 -g1 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -march=z9-109 -mtune=z10 -Wno-c++0x-compat -O2 -c Source/JavaScriptCore/runtime/ArrayConstructor.cpp  -fPIC -DPIC -o Source/JavaScriptCore/runtime/.libs/libjavascriptcoregtk_3_0_la-ArrayConstructor.o
In file included from Source/JavaScriptCore/runtime/ArrayConstructor.cpp:25:0:
Source/JavaScriptCore/runtime/ArrayConstructor.h:63:51: error: 'ArrayAllocationProfile' has not been declared
Source/JavaScriptCore/runtime/ArrayConstructor.cpp: In function 'JSC::JSObject* JSC::constructArrayWithSizeQuirk(JSC::ExecState*, const JSC::ArgList&)':
Source/JavaScriptCore/runtime/ArrayConstructor.cpp:97:77: error: call of overloaded 'constructArrayWithSizeQuirk(JSC::ExecState*&, int, JSC::JSGlobalObject*&, JSC::JSValue)' is ambiguous
Source/JavaScriptCore/runtime/ArrayConstructor.cpp:97:77: note: candidates are:
In file included from Source/JavaScriptCore/runtime/ArrayConstructor.cpp:25:0:
Source/JavaScriptCore/runtime/ArrayConstructor.h:63:11: note: JSC::JSObject* JSC::constructArrayWithSizeQuirk(JSC::ExecState*, int*, JSC::JSGlobalObject*, JSC::JSValue)
Source/JavaScriptCore/runtime/ArrayConstructor.cpp:80:11: note: JSC::JSObject* JSC::constructArrayWithSizeQuirk(JSC::ExecState*, JSC::ArrayAllocationProfile*, JSC::JSGlobalObject*, JSC::JSValue)
make[1]: *** [Source/JavaScriptCore/runtime/libjavascriptcoregtk_3_0_la-ArrayConstructor.lo] Error 1

I think the needed ArrayAllocationProfile header gets included via other headers when built with JIT enabled, but is missing in the chain when built without JIT

[WebKit Review Bot]

Attachment 179938 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dan Horák]

seems not required anymore, closing

[Chris Dumez]

Comment on attachment 179938 [details]
add missing include

Clearing flags so that this patch does not appear in the review queue.